[
https://issues.apache.org/jira/browse/TINKERPOP-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947419#comment-17947419
]
ASF GitHub Bot commented on TINKERPOP-3143:
-------------------------------------------
andreachild commented on code in PR #3101:
URL: https://github.com/apache/tinkerpop/pull/3101#discussion_r2060878223
##########
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js:
##########
@@ -39,7 +39,7 @@ const responseStatusCode = {
authenticationChallenge: 407,
};
-const defaultMimeType = 'application/vnd.gremlin-v3.0+json';
+const defaultMimeType = 'application/vnd.graphbinary-v1.0';
Review Comment:
It can be done like this:
```
it('should use default mimeType', function () {
const customClient = new Client('ws://localhost:9321', {traversalSource:
'g', connectOnStartup: false});
assert.strictEqual(customClient._connection.mimeType,
'application/vnd.graphbinary-v1.0')
});
it('should use given mimeType', function () {
const customClient = new Client('ws://localhost:9321', {traversalSource:
'g', connectOnStartup: false, mimeType: 'application/vnd.gremlin-v2.0+json'});
assert.strictEqual(customClient._connection.mimeType,
'application/vnd.gremlin-v2.0+json')
});
```
> gremlin-javascript should default to GraphBinary
> ------------------------------------------------
>
> Key: TINKERPOP-3143
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3143
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
> Affects Versions: 3.7.3
> Reporter: Stephen Mallette
> Priority: Critical
>
> no idea how this wasn't done, but gremlin-javascript is still on GraphSONv3
> as a default - should be GraphBinary like all the others. not breaking, but
> should probably be done in a major rather than 3.7.x at this point.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
