[
https://issues.apache.org/jira/browse/TINKERPOP-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18004306#comment-18004306
]
ASF GitHub Bot commented on TINKERPOP-3166:
-------------------------------------------
Cole-Greer commented on code in PR #3153:
URL: https://github.com/apache/tinkerpop/pull/3153#discussion_r2196277383
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java:
##########
@@ -1915,6 +1917,30 @@ public default GraphTraversal<S, Long> dateDiff(final
Traversal<?, ?> dateTraver
return this.asAdmin().addStep(new DateDiffStep<>(this.asAdmin(),
dateTraversal));
}
+ /**
+ * Parse value of the incoming traverser as an ISO-8601 {@link Number}.
+ *
+ * @return the traversal with an appended {@link AsNumberStep}.
+ * @see <a
href="http://tinkerpop.apache.org/docs/${project.version}/reference/#AsNumberStep-step";
target="_blank">Reference Documentation - AsNumberStep Step</a>
+ * @since 3.7.1
Review Comment:
```suggestion
* @since 3.8.0
```
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java:
##########
@@ -1915,6 +1917,30 @@ public default GraphTraversal<S, Long> dateDiff(final
Traversal<?, ?> dateTraver
return this.asAdmin().addStep(new DateDiffStep<>(this.asAdmin(),
dateTraversal));
}
+ /**
+ * Parse value of the incoming traverser as an ISO-8601 {@link Number}.
+ *
+ * @return the traversal with an appended {@link AsNumberStep}.
+ * @see <a
href="http://tinkerpop.apache.org/docs/${project.version}/reference/#AsNumberStep-step";
target="_blank">Reference Documentation - AsNumberStep Step</a>
+ * @since 3.7.1
+ */
+ public default GraphTraversal<S, Number> asNumber() {
+ this.asAdmin().getBytecode().addStep(Symbols.asNumber);
+ return this.asAdmin().addStep(new AsNumberStep<>(this.asAdmin()));
+ }
+
+ /**
+ * Parse value of the incoming traverser as an ISO-8601 {@link Number}.
+ *
+ * @return the traversal with an appended {@link AsNumberStep}.
+ * @see <a
href="http://tinkerpop.apache.org/docs/${project.version}/reference/#AsNumberStep-step";
target="_blank">Reference Documentation - AsNumberStep Step</a>
+ * @since 3.7.1
Review Comment:
```suggestion
* @since 3.8.0
```
> Add number conversion step asNumber()
> -------------------------------------
>
> Key: TINKERPOP-3166
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3166
> Project: TinkerPop
> Issue Type: Improvement
> Components: language
> Affects Versions: 3.8.0
> Reporter: Yang Xia
> Priority: Major
>
> Given the addition of the {{asString()}} and {{asDate()}} steps in the 3.7
> line, it should also be helpful to add an {{asNumber()}} step that does
> numerical casting/conversions.
> The current idea is for the {{asNumber()}} step to convert the incoming
> traverser to the nearest parsable type (e.g. int or double) if no argument is
> provided, or to the desired numerical type, based on a number token
> ({{{}N{}}}) provided. Like the {{asDate()}} step, it will not be scoped (for
> now, scopes can be added in the future).
> Some conjured examples:
> {code:java}
> gremlin> g.inject(5).asNumber()
> ==> 5 // parses to int
> gremlin> g.inject(5.123f).asNumber()
> ==> 5.123
> gremlin> g.inject(5.43).asNumber(N.int)
> ==> 5 {code}
> More details can be found in the [proposal
> doc|https://github.com/apache/tinkerpop/blob/master/docs/src/dev/future/proposal-asnumber-step-6.asciidoc].
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
