[
https://issues.apache.org/jira/browse/TINKERPOP-3168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18007870#comment-18007870
]
ASF GitHub Bot commented on TINKERPOP-3168:
-------------------------------------------
andreachild commented on code in PR #3159:
URL: https://github.com/apache/tinkerpop/pull/3159#discussion_r2213786369
##########
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/Settings.java:
##########
@@ -210,21 +210,29 @@ public Settings() {
* created {@link Session} will queue separately given that setting per
session.
* <p/>
* By default this value is set to 8192.
+ *
+ * @deprecated As of release 3.8.0, not replaced.
*/
+ @Deprecated
Review Comment:
I'm in favour of not deprecating it as its usage in
`ServerGremlinExecutor.java` has not changed from 3.8 to master. What has
changed is only its relevance to sessions, hence the removal of the javadoc
section below:
> This value should be taken in account with the {@link
#maxSessionTaskQueueSize} which is related in some respects. A request that
starts a new {@link Session} is handled by this queue, but additional requests
to a created {@link Session} will queue separately given that setting per
session.
> Deprecate UnifiedChannelizer and related infrastructure
> -------------------------------------------------------
>
> Key: TINKERPOP-3168
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3168
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.7.3
> Reporter: Stephen Mallette
> Priority: Major
>
> The {{UnifiedChannelizer}} never reached production status and has already
> been removed in 4.x, so worth marking as deprecated for 3.8.0 at this point.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
