[
https://issues.apache.org/jira/browse/TINKERPOP-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18008864#comment-18008864
]
ASF GitHub Bot commented on TINKERPOP-3023:
-------------------------------------------
Cole-Greer commented on code in PR #3138:
URL: https://github.com/apache/tinkerpop/pull/3138#discussion_r2220766035
##########
gremlin-python/src/main/python/gremlin_python/process/traversal.py:
##########
@@ -843,7 +843,7 @@ def _arg_as_string(self, arg):
return tmp
if isinstance(arg, Vertex):
- return f'new
ReferenceVertex({self._arg_as_string(arg.id)},\'{arg.label}\')'
+ return f'{self._arg_as_string(arg.id)}'
Review Comment:
Opted to implement on an individual step bases
> Expand type syntax in grammar in 3.8
> ------------------------------------
>
> Key: TINKERPOP-3023
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3023
> Project: TinkerPop
> Issue Type: Improvement
> Components: language
> Affects Versions: 3.8.0
> Reporter: Stephen Mallette
> Priority: Major
>
> There are certain types commonly used in Gremlin that should have some native
> support in the grammar:
> * UUID
> ** {{UUID()}} - random
> ** {{UUID('1e077e63-e45a-4f8e-aa00-9b6ffd91f20e')}}
> * Binary (ByteBuffer)
> ** {{Binary( '/9j/4AAQSkZJRgABAQEAAAAAAAD/==')}}
> * -Edge-
> ** -{{Edge(11)}} - different than current syntax for Vertex, adjust Vertex
> to match - drop grammar support for {{{}ReferenceVertex{}}}.-
> Update: Based on discussion in the
> [devlist|https://lists.apache.org/thread/ptq81160z4y4vddg4lxz2nv244x2yzhq],
> Edge should no longer be added, and vertex should instead be removed
> altogether.
> Update: UUID implementation has been completed in [PR
> 3112|https://github.com/apache/tinkerpop/pull/3112] and Vertex removal was
> completed for [3.8|https://github.com/apache/tinkerpop/pull/3133] and
> [4|https://github.com/apache/tinkerpop/pull/3138]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
