[
https://issues.apache.org/jira/browse/TINKERPOP-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18023884#comment-18023884
]
ASF GitHub Bot commented on TINKERPOP-2234:
-------------------------------------------
Cole-Greer commented on code in PR #3211:
URL: https://github.com/apache/tinkerpop/pull/3211#discussion_r2392513383
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/AsNumberStep.java:
##########
@@ -34,16 +34,24 @@
*/
public class AsNumberStep<S> extends ScalarMapStep<S, Number> {
- private N numberToken;
+ private GType typeToken;
public AsNumberStep(final Traversal.Admin traversal) {
super(traversal);
- this.numberToken = null;
+ this.typeToken = null;
}
- public AsNumberStep(final Traversal.Admin traversal, final N numberToken) {
+ public AsNumberStep(final Traversal.Admin traversal, final GType
numberToken) {
super(traversal);
- this.numberToken = numberToken;
+ if (!numberToken.isNumeric())
+ throw new IllegalArgumentException("asNumber() requires a numeric
type token, got " + numberToken);
+ this.typeToken = numberToken;
+ }
+
+ // TODO potential extension to use class
+ public AsNumberStep(final Traversal.Admin traversal, final Class<?>
numberToken) {
Review Comment:
Is the intention to keep this?
Nit: If it stays, the signature can be restricted slightly to
```suggestion
public AsNumberStep(final Traversal.Admin traversal, final Class<?
extends Number> numberToken) {
```
> Introduce Type Predicate
> ------------------------
>
> Key: TINKERPOP-2234
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2234
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.4.2
> Reporter: Stephen Mallette
> Priority: Major
>
> Provide for a {{typeOf()}} predicate that allows for testing the type of an
> object which would enable neat things like:
> {code}
> g.V().outE().has('weight',gt(0.1)).inV().path().unfold().is(typeOf(VERTEX))
> {code}
> See the linked DISCUSS thread for more information.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
