[ 
https://issues.apache.org/jira/browse/TINKERPOP-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stephen Mallette closed TINKERPOP-3222.
---------------------------------------
    Fix Version/s: 4.0.0
                   3.7.6
                   3.8.1
         Assignee: Stephen Mallette
       Resolution: Fixed

Fixed via CTR with: 
https://github.com/apache/tinkerpop/commit/008584d6b3766c6434c3172062b094ee8482c3b7

after doing this though, i think we ought to deprecate this strategy. it has 
way too many holes and given the direction the language has gone in the last 
few years, it can no longer be made to work properly. there are now a number of 
cases where runtime label construction gets around this strategy and the nature 
of strategies don't allow that kind of validation.

> ReservedKeysVerificationStrategy verification fails when the invalid 
> AddPropertyStep has an explicit cardinality set
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-3222
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3222
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: process
>    Affects Versions: 3.8.0, 3.7.5
>         Environment: Gremlin Console, Windows 11
> GremlinServer Docker container. 
>            Reporter: Daniel Weber
>            Assignee: Stephen Mallette
>            Priority: Minor
>             Fix For: 4.0.0, 3.7.6, 3.8.1
>
>
> Setup:
> {{g=TinkerGraph.open().traversal().withStrategies(ReservedKeysVerificationStrategy.build().throwException().create())}}
> The query
> {{g.addV().property('id', 'someId')}}
> fails correctly because "The provided traversal contains a AddVertexStartStep 
> that is setting a property key to a reserved word: id". However:
> {{g.addV().property(single, 'id', 'someId')}}
> does not and neither do
> {{g.addV().property(list, 'id', 'someId'), g.addV().property(set, 'id', 
> 'someId')}}
> So an explicitly set cardinality lets the ReservedKeysVerificationStrategy 
> miss property additions with restricted property names.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to