Ken Hu created TINKERPOP-3228:
---------------------------------

             Summary: Update GremlinSessionReuseTxIntegrateTest to test for 
Graph transaction cleanup
                 Key: TINKERPOP-3228
                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3228
             Project: TinkerPop
          Issue Type: Improvement
    Affects Versions: 3.7.6
            Reporter: Ken Hu


The tests in GremlinSessionReuseTxIntegrateTest could improve by having the 
tests verify that underlying graph in the server doesn't have any open 
transactions. The tests currently only check that the Session is removed, but 
in a forced way so the graph itself may have open transactions that need to be 
rolled back.

A problem with this, however, is that the Session uses the single threaded 
executor to run its tasks. This tasks includes closing itself, so in this case, 
the Session can't check the graph's state during close. This is further 
complicated by the Graph's Transaction implementation itself. For example, 
TinkerTransactionGraph determines "openness" on a per thread basis so it can 
appear that there is no open transaction from one thread but there may be one 
open from another.

In summary, find a way in these tests to assert that the underlying Graph 
actually has all its transactions closed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to