[ 
https://issues.apache.org/jira/browse/TINKERPOP-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18086505#comment-18086505
 ] 

ASF GitHub Bot commented on TINKERPOP-3250:
-------------------------------------------

Cole-Greer commented on code in PR #3447:
URL: https://github.com/apache/tinkerpop/pull/3447#discussion_r3365787778


##########
docs/src/reference/gremlin-variants.asciidoc:
##########
@@ -272,6 +272,47 @@ 
link:https://tinkerpop.apache.org/docs/x.y.z/dev/provider/#_graph_driver_provide
 |RequestInterceptors |Functions that modify HTTP requests before sending. Used 
for authentication and custom headers. |empty
 |=========================================================
 
+[[gremlin-go-interceptors]]
+=== RequestInterceptor
+
+Gremlin-Go allows modification of the underlying HTTP request through 
`RequestInterceptor` functions. This is
+intended to be an advanced feature which means that you will need to 
understand how the implementation works in order
+to safely utilize it. Gremlin-Go is written in a way that you should be able 
to interact with a TinkerPop-enabled
+server without having to use interceptors. This is intended for cases where 
the server has special capabilities.

Review Comment:
   > Gremlin-Go is written in a way that you should be able to interact with a 
TinkerPop-enabled
   server without having to use interceptors.
   
   I think this is too strong of a statement. It narrows the definition of a 
"TinkerPop-enabled server" to essentially just gremlin-server with default 
settings, and gate-keeps a pretty basic feature like auth for "advanced users 
only".





> Modify default request serialization to JSON
> --------------------------------------------
>
>                 Key: TINKERPOP-3250
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3250
>             Project: TinkerPop
>          Issue Type: Improvement
>            Reporter: Ken Hu
>            Priority: Major
>
> Changing the default request serialization is more aligned to how most HTTP 
> APIs operate and will allow for easier debugging. This is especially true for 
> applications that will rely on interceptors as it is difficult to see what 
> the serialized bytes are for GraphBinary.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to