[
https://issues.apache.org/jira/browse/TINKERPOP-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18094680#comment-18094680
]
ASF GitHub Bot commented on TINKERPOP-3261:
-------------------------------------------
spmallette commented on code in PR #3483:
URL: https://github.com/apache/tinkerpop/pull/3483#discussion_r3547171729
##########
gremlin-python/src/main/python/gremlin_python/structure/io/graphbinaryV4.py:
##########
@@ -611,15 +620,15 @@ def objectify(cls, buff, reader, nullable=True):
@classmethod
def _read_edge(cls, b, r):
edgeid = r.read_object(b)
- # reading single string value for now according to GraphBinaryV4
- edgelbl = r.to_object(b, DataType.list, False)[0]
+ # reading label list according to GraphBinaryV4
+ edge_labels = r.to_object(b, DataType.list, False)
inv = Vertex(r.read_object(b), r.to_object(b, DataType.list, False)[0])
Review Comment:
is this reading just one label here? shouldn't it have logic like:
https://github.com/apache/tinkerpop/pull/3483/changes#diff-7edc32e7bbb6b01ded55bbe1951532cb2807d565792ddc0ac1ba917bf497a844R66
?
> Enable multiple label support on vertex with configurable label cardinality
> ---------------------------------------------------------------------------
>
> Key: TINKERPOP-3261
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3261
> Project: TinkerPop
> Issue Type: Task
> Affects Versions: 4.0.0
> Reporter: Yang Xia
> Priority: Major
>
> Vertices are currently limited to a single immutable label assigned at
> creation. This prevents modeling common real-world scenarios where entities
> naturally belong to multiple categories (e.g., a person who is both an
> employee and a manager).
>
> Introduce a configurable LabelCardinality that controls how many labels a
> vertex may have and whether they can be mutated after creation. Three
> proposed modes: ONE (current behavior, default), ONE_OR_MORE (mutable,
> minimum one), ZERO_OR_MORE (fully flexible).
>
> New steps:
>
> - labels() — flatMap step emitting each label as a traverser
> - addLabel(String, String...) — add labels to a vertex
> - dropLabel(String, String...) — remove specific labels
> - dropLabels() — remove all labels
> Edge labels remain at cardinality ONE. The infrastructure would support
> future edge multi-label enablement without wire format changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
