[
https://issues.apache.org/jira/browse/TINKERPOP-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18118213#comment-18118213
]
ASF GitHub Bot commented on TINKERPOP-2363:
-------------------------------------------
bitflicker64 commented on PR #3672:
URL: https://github.com/apache/tinkerpop/pull/3672#issuecomment-5788702530
> Hi and thanks for contributing. Changes to the 3.7-dev branch are now
reserved for non-breaking changes. But this might classify as a bug fix. We'll
see what other contributors have to say. At the very least this would go into
master.
>
> In any case, I took a quick look and the changes seem fine. Will take a
slightly more in-depth look soon.
>
> Thanks again.
Thanks, master is fine if that is safer. For the bug-fix question:
TINKERPOP-2943 is the same report and was closed as a duplicate of 2363 with
this fix suggested. The only behavior change is for values that used to raise
struct.error; everything else serializes byte-identically.
> GraphBinary and numerics for Python
> -----------------------------------
>
> Key: TINKERPOP-2363
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2363
> Project: TinkerPop
> Issue Type: Improvement
> Components: python
> Affects Versions: 3.4.6
> Reporter: Stephen Mallette
> Priority: Critical
>
> After TINKERPOP-2360 we've started down the path of coercing python numerics
> to Java type ranges. GraphBinary doesn't do that and therefore switching
> serializers from GraphSON to GraphBinary will have the potential to result in
> error if the python numeric overflows the Java integer space. In addition, we
> don't support {{BigInteger}} serialization apparently so that remains a
> problem. This ticket should just sort out GraphBinary and numbers all at once.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
