[
https://issues.apache.org/jira/browse/TINKERPOP-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18120850#comment-18120850
]
ASF GitHub Bot commented on TINKERPOP-3248:
-------------------------------------------
Cole-Greer commented on code in PR #3673:
URL: https://github.com/apache/tinkerpop/pull/3673#discussion_r4136740612
##########
gremlin-js/gremlin-javascript/test/unit/translator/gremlin-translator-test.js:
##########
@@ -285,6 +285,14 @@ describe('GoTranslateVisitor', function () {
['g.inject(Duration(9000,0))', 'g.Inject(time.Duration(9000000000000))'],
// Binary literal
['g.inject(Binary("AQID"))', 'g.Inject(gremlingo.ByteBuffer{Data:
[]byte{1,2,3}})'],
+ // Character literals
+ ['g.inject("a"c)', "g.Inject(gremlingo.Char('a'))"],
+ ['g.inject("\\""c)', "g.Inject(gremlingo.Char('\"'))"],
+ ['g.inject("\\\\"c)', "g.Inject(gremlingo.Char('\\\\'))"],
+ ["g.inject(\"'\"c)", "g.Inject(gremlingo.Char('\\''))"],
Review Comment:
Nevermind, that extra is for the JS layer
> Character support in gremlin-go
> -------------------------------
>
> Key: TINKERPOP-3248
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3248
> Project: TinkerPop
> Issue Type: Improvement
> Components: go
> Affects Versions: 3.8.1
> Reporter: Ken Hu
> Priority: Major
>
> gremlin-go doesn't support the Character right now but it should be
> representable with Rune. Add this to both GremlinLang and GraphBinary in
> gremlin-go.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
