[
https://issues.apache.org/jira/browse/TINKERPOP-3059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18125733#comment-18125733
]
ASF GitHub Bot commented on TINKERPOP-3059:
-------------------------------------------
kenhuuu commented on PR #3714:
URL: https://github.com/apache/tinkerpop/pull/3714#issuecomment-6093425780
The added unit tests are good and directly test the implemented fix however
it doesn't actually test `option()`. What's needed to cover this are feature
tests. In the `3.8-dev` branch you can assert for errors during traversal
construction due a small change in the test harness. I think you should
backport that harness fix and add feature tests for this change.
> Prevent repeated option() calls to merge steps
> ----------------------------------------------
>
> Key: TINKERPOP-3059
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3059
> Project: TinkerPop
> Issue Type: Improvement
> Components: language, process
> Affects Versions: 3.7.1
> Reporter: Stephen Mallette
> Priority: Critical
>
> Could avoid some confusion if we prevented:
> {code}
> mergeV(...).
> option(onCreate, ...).
> option(onCreate, ...).
> option(onCreate, ...)....
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
