[
https://issues.apache.org/jira/browse/TINKERPOP-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18131100#comment-18131100
]
ASF GitHub Bot commented on TINKERPOP-3260:
-------------------------------------------
kenhuuu commented on code in PR #3674:
URL: https://github.com/apache/tinkerpop/pull/3674#discussion_r4363282740
##########
docs/src/upgrade/release-4.x.x.asciidoc:
##########
@@ -1313,6 +1313,9 @@ const connection = new
DriverRemoteConnection('https://localhost:8182/gremlin',
});
----
+NOTE: `auth.sigv4()` is only supported in Node.js. It throws an error when
called in a browser, where `auth.basic()`
Review Comment:
Nit: Remove this. Don't change existing upgrade documentation.
> Browser testing for gremlin-javascript
> --------------------------------------
>
> Key: TINKERPOP-3260
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3260
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver
> Affects Versions: 4.0.0
> Reporter: Guian Gumpac
> Priority: Major
> Fix For: 4.0.0
>
>
> It would be nice to have some sort of smoke test to verify changes in
> gremlin-javascript still allows for the driver to work for browsers. Close
> https://issues.apache.org/jira/browse/TINKERPOP-2143 once this is properly
> tested.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
