[
https://issues.apache.org/jira/browse/TINKERPOP-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18132667#comment-18132667
]
ASF GitHub Bot commented on TINKERPOP-3095:
-------------------------------------------
Cole-Greer commented on code in PR #3727:
URL: https://github.com/apache/tinkerpop/pull/3727#discussion_r4331051267
##########
CHANGELOG.asciidoc:
##########
@@ -26,6 +26,7 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
=== TinkerPop 4.0.0 (Release Date: NOT OFFICIALLY RELEASED YET)
* Added a `Char` type to `gremlin-go` to represent the Gremlin `Character`
type in `GremlinLang`.
+* Added a way to select the script engine for traversal-based requests in all
GLVs, either per traversal source with `with("language", "gremlin-lang")` or as
a `DriverRemoteConnection` default (`DriverRemoteConnection.using(cluster, "g",
"gremlin-lang")` in Java, `language=` in Python and .NET, `RequestLanguage` in
Go, and the `language` option in JavaScript).
Review Comment:
Nit: changelog entries should be kept super short, perhaps something like
this:
```suggestion
* Added a way to select the script language for traversal-based requests,
either via `with("language", "gremlin-lang")` connection option.
```
> Provide a path for selecting script engine for traversals in TP4
> ----------------------------------------------------------------
>
> Key: TINKERPOP-3095
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3095
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver
> Affects Versions: 4.0.0
> Reporter: Valentyn Kahamlyk
> Priority: Critical
>
> For string queries there is now a simple way to select script engine which
> the query will be executed
> {code:java}
> final RequestOptions ro =
> RequestOptions.build().language("gremlin-lang").create();
> final List result = client.submit("g.inject(1)", ro).toList();{code}
> We need to do the same thing for traversal based requests, Something like
> {code:java}
> final GraphTraversalSource g =
> traversal().with(DriverRemoteConnection.using(cluster)).with("language",
> "gremlin-lang");
> final List result = g.inject(1).toList());{code}
> *or*
> {code:java}
> final GraphTraversalSource g =
> traversal().with(DriverRemoteConnection.using(cluster, "g", "gremlin-lang));
> final List result = g.inject(1).toList());{code}
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
