[
https://issues.apache.org/jira/browse/TINKERPOP-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18136600#comment-18136600
]
ASF GitHub Bot commented on TINKERPOP-3291:
-------------------------------------------
Cole-Greer commented on PR #3758:
URL: https://github.com/apache/tinkerpop/pull/3758#issuecomment-6583115288
VOTE +1
> Consider refactoring to TinkerStorageGraph structure
> ----------------------------------------------------
>
> Key: TINKERPOP-3291
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3291
> Project: TinkerPop
> Issue Type: Improvement
> Components: tinkergraph
> Affects Versions: 4.0.0
> Reporter: Stephen Mallette
> Priority: Major
>
> Determine if we could push down all durable storage state logic out of
> {{AbstractTinkerGraph}} into {{TinkerStorageGraph}} since such logic really
> only applies to that implementation. The {{TinkerStorage}} interface takes
> {{AbstractTinkerGraph}} in {{open}}, {{replay}}, {{compact}} and
> {{maybeCompact}}, and {{GraphBinaryStorage.writeSnapshot}} calls
> {{graph.committedVertices()}}. Moving everything down therefore means
> retyping the interface to take {{TinkerStorageGraph}}.
>
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
