[ 
https://issues.apache.org/jira/browse/TINKERPOP-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18136768#comment-18136768
 ] 

ASF GitHub Bot commented on TINKERPOP-3290:
-------------------------------------------

spmallette opened a new pull request, #3760:
URL: https://github.com/apache/tinkerpop/pull/3760

   https://issues.apache.org/jira/browse/TINKERPOP-3290
   
   A closed TinkerMemoryGraph or TinkerStorageGraph now throws 
IllegalStateException when used through the Graph API, a traversal, or a 
previously obtained element.
   
   VOTE +1
   
   <!--
   Thanks for contributing! Reminders:
   + TARGET the earliest branch where you want the change
       3.7-dev -> 3.7.7 (non-breaking only)
       3.8-dev -> 3.8.2 (non-breaking only)
       master  -> 4.0.0
   + Committers will MERGE the PR forward to newer versions
   + ADD entry to the CHANGELOG.asciidoc for the targeted version
       Do not reference a JIRA number there
   + ADD JIRA number to title and link in description
   + PRs requires 3 +1s from committers OR
                  1 +1 and 7 day wait to merge.
   + MORE details: https://s.apache.org/rtnal
   -->




> TinkerGraph close() semantics should prevent further usage
> ----------------------------------------------------------
>
>                 Key: TINKERPOP-3290
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3290
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: tinkergraph
>    Affects Versions: 3.8.2
>            Reporter: Stephen Mallette
>            Priority: Critical
>
> {code}
> gremlin> graph = TinkerGraph.open()
> ==>tinkergraph[vertices:0 edges:0]
> gremlin> g = traversal().with(graph)
> ==>graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
> gremlin> g.addV('person')
> ==>v[0]
> gremlin> g.V().count()
> ==>1
> gremlin> graph.close()
> ==>null
> gremlin> g.addV('person')
> ==>v[1]
> gremlin> g.V().count()
> ==>2
> {code}
> This will be at odds with the file-persistent version of TinkerGraph in 4.0 
> where we will need {{close()} to actually prevent further usage. Need to 
> align the pure in-memory graph with that.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to