[ 
https://issues.apache.org/jira/browse/TINKERPOP-2558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18146875#comment-18146875
 ] 

ASF GitHub Bot commented on TINKERPOP-2558:
-------------------------------------------

spmallette commented on code in PR #3809:
URL: https://github.com/apache/tinkerpop/pull/3809#discussion_r4617949439


##########
docs/src/upgrade/release-4.x.x.asciidoc:
##########
@@ -332,6 +332,64 @@ extension methods from `DefaultGroovyMethods` to 
`ArrayGroovyMethods`. An allowl
 See: 
link:https://tinkerpop.apache.org/docs/4.0.0/reference/#gremlin-console[Reference
 Documentation - Gremlin Console],
 
link:https://docs.groovy-lang.org/docs/groovy-6.0.0/html/documentation/groovysh.html[groovysh
 Documentation]
 
+==== Geospatial Data
+
+Graphs have long held locations, but Gremlin had no native type for them, so a 
geometry traveled as a string or as a
+provider defined type and each graph settled on a representation of its own, 
which left no spatial filter portable
+between them. TinkerPop 4.0.0 adds `Geometry` as a Gremlin value type with the 
kinds `Point`, `LineString`, `Polygon`,
+`MultiPoint`, `MultiLineString`, `MultiPolygon` and `GeometryCollection`.
+
+A geometry is written in a traversal with the `Geometry(...)` literal, which 
is also spelled `geometry(...)`. Its first

Review Comment:
   I'm not sure it's clear what we are referring to here with this syntax. the 
later end of the paragraph alludes to the Java syntax, which is helpful down 
there but not clarifying much in the initial sentence. I guess we don't have 
all the GLVs done so we probably don't need other context, but then if we had 
them i wonder if we would bother in the upgrade docs. maybe it shouldn't 
mention Java at all? I also feel like much of this is user documentation rather 
than talking about the introduction of the feature itself. Seems like it should 
be refocused to talk about the capability more than some of these intricate 
details. it does have some words on limitations with geo in this release which 
is helpful. 





> GEO Spatial APIs
> ----------------
>
>                 Key: TINKERPOP-2558
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2558
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.5.0
>            Reporter: Jitesh
>            Priority: Major
>
> Provide support for Geo based APIs (predicates, objects, etc)
>  
>  



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to