[
https://issues.apache.org/jira/browse/TINKERPOP3-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945368#comment-14945368
]
ASF GitHub Bot commented on TINKERPOP3-850:
-------------------------------------------
GitHub user mhfrantz opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/102
TINKERPOP3-850 Reduce Graph.addVertex overload ambiguity (v1)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RedSeal-co/incubator-tinkerpop
chore/TINKERPOP3-850-Reduce-Graph-addVertex-overload-ambiguity_104440766.v1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/102.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #102
----
commit f94a9542b3966d8be415369462b8d23e98432686
Author: mhfrantz <mfra...@redsealnetworks.com>
Date: 2015-10-03T18:55:24Z
GraphTest: Declare FEATURE_STRING_VALUES where it had been implicitly
required
commit be5017f104614e2289e3769b9880003e6d7657d4
Author: mhfrantz <mfra...@redsealnetworks.com>
Date: 2015-10-03T19:00:52Z
GraphTest: Rename addVertex test to better reflect the desired behavior
commit d369d1bae3575734b57479e374b9c73341f67f24
Author: mhfrantz <mfra...@redsealnetworks.com>
Date: 2015-10-03T19:25:00Z
GraphTest: Add more tests for various addVertex use cases
commit 31e2750efd0c7dce0a117deb1dedb168f7edd808
Author: mhfrantz <mfra...@redsealnetworks.com>
Date: 2015-10-03T22:37:46Z
TINKERPOP3-867: TinkerGraphProvider.getBaseConfiguration creates temp dir
as needed for persistence testing
commit 5171a33c94f92238c6efcd4468642ffab8ccbfb0
Author: mhfrantz <mfra...@redsealnetworks.com>
Date: 2015-10-03T22:38:53Z
TINKERPOP3-850: Reduce Graph.addVertex overload ambiguity
----
> Reduce Graph.addVertex overload ambiguity
> -----------------------------------------
>
> Key: TINKERPOP3-850
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-850
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.0.1-incubating
> Reporter: Matt Frantz
> Assignee: Matt Frantz
> Fix For: 3.1.0-incubating
>
>
> Create the following overloads:
> {noformat}
> Vertex addVertex();
> Vertex addVertex(String label);
> Vertex addVertex(Object key, Object value, Object...keyValues);
> {noformat}
> This would avoid the 1-arg overload, since there is only one 1-arg variant.
> It also makes the key/value structure more obvious.
> BTW, the JavaDoc now says "...the odd numbered arguments are String property
> keys," so if we actually allow other types, that doc should be fixed.
> Motivated by this dicussion:
> https://groups.google.com/d/msgid/gremlin-users/eb2a451a-af66-48a1-989c-8021473647fc%40googlegroups.com
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
