[
https://issues.apache.org/jira/browse/TINKERPOP3-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956898#comment-14956898
]
Marko A. Rodriguez commented on TINKERPOP3-850:
-----------------------------------------------
I'm going to change my vote to a -1 as I don't think this is a good idea. There
are numerous "hacks" I've done in Gremlin-Groovy because of incompatibilities
between Groovy and Java. This seems analogous to that situation but with Scala.
I don't think we should change our core APIs and the Java-style of our APIs
just to make Scala happy. However, with that, I'm more than happy to change my
VOTE once I get a good explanation of:
* How did Gremlin-Scala solve this before? Obviously Gremlin-Scala works now.
* Why should we deviate from the Java8 method structure just to make one
language happy?
* How is {{addVertex(Object[])}} and different from {{addVertex(Object...)}}?
VOTE -1.
> Reduce Graph.addVertex overload ambiguity
> -----------------------------------------
>
> Key: TINKERPOP3-850
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-850
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.0.1-incubating
> Reporter: Matt Frantz
> Assignee: Matt Frantz
> Labels: breaking
> Fix For: 3.1.0-incubating
>
>
> Create the following overloads:
> {noformat}
> Vertex addVertex();
> Vertex addVertex(String label);
> Vertex addVertex(Object key, Object value, Object...keyValues);
> {noformat}
> This would avoid the 1-arg overload, since there is only one 1-arg variant.
> It also makes the key/value structure more obvious.
> BTW, the JavaDoc now says "...the odd numbered arguments are String property
> keys," so if we actually allow other types, that doc should be fixed.
> Motivated by this dicussion:
> https://groups.google.com/d/msgid/gremlin-users/eb2a451a-af66-48a1-989c-8021473647fc%40googlegroups.com
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
