[
https://issues.apache.org/jira/browse/TINKERPOP3-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14961180#comment-14961180
]
ASF GitHub Bot commented on TINKERPOP3-858:
-------------------------------------------
Github user pluradj commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/110#issuecomment-148801984
@dkuppitz `DependencyGrabber.copyDependenciesToPath()` throws two
exceptions explicitly, `IOException` and `IllegalStateException`.
`RuntimeException` occurs if there is an error grabbing grapes. This is the
initial bug report, and its failed directory should be rolled back.
`IOException` occurs if there are problems creating the directories under
`ext`. Rollback should occur here, but most likely there isn't even a directory
to delete.
`IllegalStateException` occurs if plugin module already exists. For
example, `tinkergraph-gremlin` is installed by default out of the box. If the
code doesn't catch the `IllegalStateException`, `tinkergraph-gremlin` would get
*uninstalled* if the user tried to install it a second time.
> Cleanup after failed :install
> -----------------------------
>
> Key: TINKERPOP3-858
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-858
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: console, server
> Affects Versions: 3.0.1-incubating
> Reporter: stephen mallette
> Assignee: Jason Plurad
> Priority: Minor
> Fix For: 3.1.0-incubating, 3.0.2-incubating
>
>
> If {{:install}} tanks:
> {code}
> gremlin> :install org.apache.tinkerpop hadoop-gremlin 3.1.0-SNAPSHOT
> ==>Error grabbing Grapes -- [download failed:
> io.netty#netty;3.6.2.Final!netty.jar(bundle)]
> {code}
> try to clean up the directory that gets created or else future attempts do
> this:
> {code}
> gremlin> :install org.apache.tinkerpop hadoop-gremlin 3.1.0-SNAPSHOT
> ==>a module with the name hadoop-gremlin is already installed
> {code}
> This is also a problem for {{bin/gremlin-server.sh -i}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
