[
https://issues.apache.org/jira/browse/TINKERPOP3-884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP3-884.
---------------------------------------
Resolution: Won't Fix
Fix Version/s: (was: 3.1.0-incubating)
I knew this work looked familiar. We merged a PR from David Robinson on this
at: TINKERPOP3-713 so groovy-all has been gone for a while. The strange part
is that we still have those extraneous groovy libs present in the distribution.
After some research, I've learned that groovy-groovysh brings groovy-console,
which in turn brings groovy-templates and groovy-swing. groovy-templates
brings groovy-xml. We could do some {{<exclusion>}} work, but I don't think we
should mess with that hierarchy and accidentally cause something to stop
working.
We do explicitly bring in groovy-json but i don't think that's bad and at this
point we're only saving a 200k by removing it. It has some usage with respect
to Gremlin Server and processing raw GraphSON results. anyway, I think I'm
just going to close this one. Sorry to kick up a lot of dust on this one for
work already done, but I didn't realize the ways in which groovy was
interdependent on itself.
> Clean up groovy-all dependency in gremlin-groovy
> ------------------------------------------------
>
> Key: TINKERPOP3-884
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-884
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: groovy
> Affects Versions: 3.0.1-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Labels: breaking
>
> Specifically, I think we could drop:
> + groovy-console
> + groovy-swing
> + groovy-templates
> + groovy-xml
> without any specific changes to code. we could likely exclude (with minor
> code change):
> + groovy-sql
> + groovy-json
> note that this change will affect the binary LICENSE/NOTICE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
