GitHub user okram opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/127

    TINKERPOP3-918: ComputerVerificationStrategy is too restrictive

    @dkuppitz found a restrictive verification that has now been loosened up. I 
added the two examples that Kuppitz demonstrated that should be allowed but 
were not. In the process, I found a bug in how MapReduce comparators work and 
fixed it. 
    
    I ran `mvn clean install`. I also did Spark integration testing and tested 
the known tests that this effects in Giraph.
    
    When merged, I will updated CHANGELOG.
    
    VOTE +1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-918

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #127
    
----
commit d9cf614fcb1355a33bdf1ec007aa569f561f32b3
Author: Marko A. Rodriguez <[email protected]>
Date:   2015-10-28T21:30:31Z

    Fixed. There is now TraversalHelper.isNotBeyondElementId(). This ensures 
that any CollectingBarrierStep or other end-step for TraverserMapReduce throws 
a ComputerVerificationStrategyException is the by() modulation tries to touch 
anything more than the Element id (though if its a string, list, etc. that is 
okay). I added @dkuppitz two examples that should work and now they do work. 
Furthermore, all existing traversal tests pass.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to