[
https://issues.apache.org/jira/browse/TINKERPOP3-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14994520#comment-14994520
]
ASF GitHub Bot commented on TINKERPOP3-885:
-------------------------------------------
Github user PommeVerte commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/113#issuecomment-154552506
Ok sorry about the delay with this. It took me some time to wrap my head
around the StandardStructureTestSuit and adding my crappy testing env to that
suddenly made things way more complicated.
Anyways I've tested this with :
```
mvn clean install -DincludeNeo4j
```
And I've also run related integration tests (though not all as my poor
ubuntu VM wouldn't manage.. I'm going to fix the builds on my mac this weekend
to have a clean dev environment and avoid this in the future)
I haven't managed to run the tests against titan though (for the threaded
transactions) If someone could give those a look it would perfect. Normally the
tests should be properly written.
Thanks!!
> Change Transaction.onReadWrite() to be a ThreadLocal setting
> ------------------------------------------------------------
>
> Key: TINKERPOP3-885
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-885
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: server, structure
> Affects Versions: 3.0.2-incubating
> Reporter: Dylan Millikin
> Assignee: Dylan Millikin
> Labels: breaking
> Fix For: 3.1.0-incubating
>
>
> The issue is as follows:
> Because Transaction consumers are global for a graph. A
> {{SessionOpProcessor}} request will change the Transaction read write
> behavior to {{MANUAL}} across all concurrent/future requests.
> This will make other requests fail (ones expecting {{AUTO}}).
> This has been discussed here :
> http://mail-archives.apache.org/mod_mbox/incubator-tinkerpop-dev/201510.mbox/browser
> The solution would be to make Transaction consumers ThreadLocal to keep the
> state local to the requests.
> This is a breaking change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
