[ 
https://issues.apache.org/jira/browse/TINKERPOP3-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15000688#comment-15000688
 ] 

ASF GitHub Bot commented on TINKERPOP3-955:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/143

    TINKERPOP3-955 Registered HashMap$Node to GryoMapper.

    https://issues.apache.org/jira/browse/TINKERPOP3-955
    
    Note that this class had to be registered via reflection as it is a private 
class of HashMap. Added tests to validate that the change works with the code 
specified in the issue. 
    
    Please review as it pertains to area of serialization that you are familiar 
with.  To test with gremlin-server you need to run the integration tests:
    
    ```text
    mvn clean install
    mvn verify -pl gremlin-server -DskipIntegrationTests=false
    ```
    
    VOTE: +1
    
    btw, we _could_ postpone this to 3.1.1 if we wanted - i think. there is a 
workaround to the bug in that the person just doesn't have to `next()` the 
result to get it to serialize.  

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-955

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #143
    
----
commit 8b70c5cf81ac0fbd5246489c91ef864ae2247495
Author: Stephen Mallette <[email protected]>
Date:   2015-11-11T16:42:44Z

    TINKERPOP3-955 Registered HashMap$Node to GryoMapper.
    
    Note that this class had to be registered via reflection as it is a private 
class of HashMap. Added tests to validate that the change works with the code 
specified in the issue.

----


> HashMap$Node not serializable
> -----------------------------
>
>                 Key: TINKERPOP3-955
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-955
>             Project: TinkerPop 3
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.1.0-incubating
>            Reporter: Bob Briody
>            Assignee: stephen mallette
>
> The following code
> m = g.V().groupCount().by(bothE().count()).next()
> m
> causes the following error when executed via gremlin server
> java.util.concurrent.ExecutionException: 
> org.apache.tinkerpop.gremlin.driver.ser.SerializationException: 
> java.lang.IllegalArgumentException: Class is not registered: 
> java.util.HashMap$Node
> Note: To register this class use: kryo.register(java.util.HashMap$Node.class);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to