GitHub user ellitron opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/152
Fixed feature check in shouldPersistDataOnClose()
GraphTests.shouldPersistDataOnClose checked that *edges* supported String
type properties before adding String type properties to *vertices*. Changed
this check to be consistent with the operation being performed.
Additional Notes:
1) This unit test adds properties to vertices, but does not *explicitly*
make the check for Graph.Features.VertexFeatures.FEATURE_ADD_PROPERTY support
in its feature requirements. The feature requirement set SIMPLE does not
include Graph.Features.VertexFeatures.FEATURE_ADD_PROPERTY, but rather includes
the feature Graph.Features.VertexPropertyFeatures.FEATURE_ADD_PROPERTY, which
is a check for being able to add meta properties. Therefore, since meta
properties cannot be supported without basic add property support for vertices,
the check for adding properties to vertices is *implicit*, not explicit.
2) Although Graph.Features.VertexPropertyFeatures.FEATURE_ADD_PROPERTY is
included in the feature set requirements for this unit test, this unit test
does not actually depend on meta property support. This unit test will not run
for graphs that support persistence, but do not support meta properties.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ellitron/incubator-tinkerpop patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #152
----
commit d828252fa3f13523469d5932802b99f856a6fc79
Author: Jonathan Ellithorpe <[email protected]>
Date: 2015-11-21T20:15:37Z
Fixed feature check in shouldPersistDataOnClose()
GraphTests.shouldPersistDataOnClose checked that *edges* supported String
type properties before adding String type properties to *vertices*. Changed
this check to be consistent with the operation being performed.
Additional Notes:
1) This unit test adds properties to vertices, but does not *explicitly*
make the check for Graph.Features.VertexFeatures.FEATURE_ADD_PROPERTY support
in its feature requirements. The feature requirement set SIMPLE does not
include Graph.Features.VertexFeatures.FEATURE_ADD_PROPERTY, but rather includes
the feature Graph.Features.VertexPropertyFeatures.FEATURE_ADD_PROPERTY, which
is a check for being able to add meta properties. Therefore, since meta
properties cannot be supported without basic add property support for vertices,
the check for adding properties to vertices is *implicit*, not explicit.
2) Although Graph.Features.VertexPropertyFeatures.FEATURE_ADD_PROPERTY is
included in the feature set requirements for this unit test, this unit test
does not actually depend on meta property support. This unit test will not run
for graphs that support persistence, but do not support meta properties.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
