[
https://issues.apache.org/jira/browse/TINKERPOP3-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023150#comment-15023150
]
ASF GitHub Bot commented on TINKERPOP3-970:
-------------------------------------------
GitHub user okram opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/153
TINKERPOP3-970: ProfileStep should be off Traversal, not GraphTraversal
https://issues.apache.org/jira/browse/TINKERPOP3-970
A couple things.
* `Traversal.profile()` now exists. The point of the ticket.
* `__.profile()` does not exist. This shouldn't have been there to begin
with.
Ran `mvn clean install` and all is golden.
VOTE +1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-970
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/153.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #153
----
commit c23a69bac5967292ee566ec8af4e71663be3034c
Author: Marko A. Rodriguez <[email protected]>
Date: 2015-11-23T21:45:02Z
profile()-step is now off of Traversal as it is generally useful beyond
GraphTraversal. The philosophy here is the one we used for why Traversal has
next(), hasNext(), toList(), toSet(), explain(), iterate(), etc. Next, I
removed __.profile() as method as you should never profile like that....weird.
I updated the GraphTraversalTest accordingly. Ran mvn clean insatll and all is
golden. This is backwards compatible save the __.profile()-removal which
wouldn't work anyways so......
----
> ProfileStep should be off Traversal, not GraphTraversal
> -------------------------------------------------------
>
> Key: TINKERPOP3-970
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-970
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.1.0-incubating
> Reporter: Marko A. Rodriguez
> Assignee: Marko A. Rodriguez
> Fix For: 3.1.1-incubating
>
>
> We currently have {{GraphTraversal.profile()}} but NOT
> {{Traversal.profile()}}. This should be put at the {{Traversal}}-level as its
> universal to all traversals much like {{explain()}}, {{toList()}},
> {{toSet()}}, {{toStream()}}, {{iterate()}}, {{hasNext()}}, {{next()}}, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
