Hi, Note that this morning I merged Marvin's PR regarding complex IDs in the Groovy test suite (master/). If you guys could verify that all is cherry, that would be great. Note that I added a UUIDGraph that will ensure that we have tests for complex IDs so we don't have to rely on OrientDB verifying things.
Thanks, Marko. http://markorodriguez.com On Nov 23, 2015, at 4:15 PM, Michael Pollmeier <[email protected]> wrote: > Cool. > > I haven't tried it in Gremlin-Server. > > On 11/21/2015 01:07 AM, Stephen Mallette wrote: >> You have one other reference to "driver" in the code itself as a top-level >> directory name: >> >> https://github.com/mpollmeier/orientdb-gremlin/tree/master/driver >> >> but what you have looks good to me. >> >> Have you tried to configure OrientDb in Gremlin Server? that was always a >> pain point for Rexster - i'm hoping it would be all good for Gremlin Server >> as folks have complained about that integration point in the past. >> >> On Thu, Nov 19, 2015 at 5:37 PM, Michael Pollmeier < >> [email protected]> wrote: >> >>> No problem, just renamed it - looking good? >>> https://github.com/mpollmeier/orientdb-gremlin >>> >>> >>> On 11/20/2015 09:51 AM, Stephen Mallette wrote: >>> >>>> Just a suggestion, but it occurred to me that you are using the term >>>> "driver" to describe your work, when in TinkerPop parlance you are have a >>>> "Graph Structure Implementation". We've been using the term "driver" to >>>> refer to language bindings to Gremlin Server. That might be something to >>>> change before you get very official with release as it could confuse >>>> folks. >>>> >>>> On Thu, Nov 19, 2015 at 3:41 PM, Michael Pollmeier < >>>> [email protected]> wrote: >>>> >>>> Hi Marko, >>>>> >>>>> Don't let the release numbers of the driver confuse you, it actually >>>>> always depended on the latest released TP3 - currently 3.0.2-incubating. >>>>> I've just released 3.0.2-incubating.0 of the driver to be less confusing: >>>>> https://github.com/mpollmeier/orientdb-gremlin/releases >>>>> >>>>> I might have been a bit over-optimistic on the standard test suite >>>>> results >>>>> - we still have a few failures and opt-out areas: >>>>> Tests run: 818, Failures: 2, Errors: 12, Skipped: 373 >>>>> >>>>> Here's our thread to try and fix the remaining issues: >>>>> https://github.com/mpollmeier/orientdb-gremlin/pull/26 >>>>> @velo has done a great job fixing them, but these last ones are a bit >>>>> more >>>>> tricky. So we need some help from someone who knows what they're doing :) >>>>> First step seems to be to fix this open issue: >>>>> https://issues.apache.org/jira/browse/TINKERPOP3-945 >>>>> >>>>> Cheers >>>>> Michael >>>>> >>>>> >>>>> >>>>> On 11/20/2015 06:20 AM, Marko Rodriguez wrote: >>>>> >>>>> Hi Michael, >>>>>> >>>>>> I note that the releases are still in the MX series of TinkerPop3. >>>>>> https://github.com/mpollmeier/orientdb-gremlin/releases >>>>>> >>>>>> Can we do this? >>>>>> >>>>>> 1. Do a 3.1.0 release (when it finally goes through Apache >>>>>> general@ VOTE). >>>>>> - Note its gone through dev@ VOTE so you can be >>>>>> confident about building against it now. >>>>>> 2. I can help do a OrientDB/TinkerPop logo for the README. >>>>>> (Luca: >>>>>> thoughts/concerns?) >>>>>> 3. We then promote on gremlin-users@, a press release about >>>>>> 3.1.0 that is planned, and of course, good ol' Twitter. >>>>>> 4. Add to the Apache TinkerPop homepage. >>>>>> >>>>>> Thoughts?, >>>>>> Marko. >>>>>> >>>>>> http://markorodriguez.com >>>>>> >>>>>> On Nov 19, 2015, at 3:56 AM, Dylan Millikin <[email protected]> >>>>>> wrote: >>>>>> >>>>>> This is awesome news. I had been keeping an eye on this recently and can >>>>>> >>>>>>> vouch for the effort that went into it. >>>>>>> >>>>>>> Cheers! >>>>>>> >>>>>>> On Thu, Nov 19, 2015 at 11:51 AM, Stephen Mallette < >>>>>>> [email protected] >>>>>>> >>>>>>>> >>>>>>>> wrote: >>>>>>> >>>>>>> Nice, Michael - and thanks to other contributors who got this running >>>>>>> if >>>>>>> >>>>>>>> they are listening in. If you have the test suite running >>>>>>>> successfully, >>>>>>>> that's the usual criteria for TinkerPop to promote a provider >>>>>>>> implementation so I'd expect some tweeting and stuff later when Marko >>>>>>>> comes >>>>>>>> online. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Nov 19, 2015 at 12:08 AM, Luca Garulli <[email protected]> >>>>>>>> wrote: >>>>>>>> >>>>>>>> Hey Michael, >>>>>>>> >>>>>>>>> That's super cool, you accelerated our roadmap for OrientDB v3.0! I >>>>>>>>> see >>>>>>>>> some features are not supported by default, but we can definitely >>>>>>>>> help >>>>>>>>> on >>>>>>>>> this. >>>>>>>>> >>>>>>>>> Thanks. >>>>>>>>> >>>>>>>>> On 18 November 2015 at 22:44, Michael Pollmeier < >>>>>>>>> [email protected]> wrote: >>>>>>>>> >>>>>>>>> Thanks to a huge combined effort ( >>>>>>>>> >>>>>>>>>> https://github.com/mpollmeier/orientdb-gremlin/graphs/contributors) >>>>>>>>>> >>>>>>>>>> the >>>>>>>>> >>>>>>>> >>>>>>>> orient tp3 driver is not experimental any more. In fact, we're already >>>>>>>>> >>>>>>>>>> using it in production. >>>>>>>>>> >>>>>>>>>> The standard tinkerpop test suite for database drivers passes. >>>>>>>>>> >>>>>>>>>> The main area that still needs some more work is index lookups - >>>>>>>>>> >>>>>>>>>> currently >>>>>>>>> >>>>>>>>> it does find the right index for a simple case, e.g. >>>>>>>>>> g.V.hasLabel("myLabel").has("someKey", "someValue"). However if >>>>>>>>>> there >>>>>>>>>> >>>>>>>>>> are >>>>>>>>> >>>>>>>> >>>>>>>> multiple indexes on the same property, or if there the traversal >>>>>>>>> should >>>>>>>>> >>>>>>>>>> better use a composite index, that's not handled well yet (it just >>>>>>>>>> >>>>>>>>>> picks >>>>>>>>> >>>>>>>> >>>>>>>> the first matching index). >>>>>>>>> >>>>>>>>>> >>>>>>>>>> Do you want to add it back to the front page ( >>>>>>>>>> http://tinkerpop.incubator.apache.org/) ? >>>>>>>>>> >>>>>>>>>> Cheers >>>>>>>>>> Michael >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>> >>>>>> >>>> >>
