[
https://issues.apache.org/jira/browse/TINKERPOP3-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033583#comment-15033583
]
ASF GitHub Bot commented on TINKERPOP3-995:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/162
TINKERPOP3-995 Add Authenticator.newSaslNegotiator(InetAddress)
https://issues.apache.org/jira/browse/TINKERPOP3-995
This change is non-breaking despite the deprecation. Reviewers should focus
on validating that there are no regressions:
```text
mvn clean install
mvn verify -DskipIntegrationTests=false -pl gremlin-server
```
VOTE: +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-995
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/162.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #162
----
commit 88b85c864ba82d0935a9834015e13358aaca46ec
Author: Stephen Mallette <[email protected]>
Date: 2015-11-26T12:41:19Z
Deprecated Authenticator.newSaslNegotiator() and added new method to
replace.
commit aec1bfff9ead41a5c7ebad542b872bfb00adb43d
Author: Stephen Mallette <[email protected]>
Date: 2015-12-01T11:09:38Z
Update upgrade docs on Authenticator changes.
commit 6f8c580184dd3e02b94bed4764d3948ff785a249
Author: Stephen Mallette <[email protected]>
Date: 2015-12-01T12:07:33Z
Updated changelog.
----
> Add Authenticator.newSaslNegotiator(InetAddress)
> ------------------------------------------------
>
> Key: TINKERPOP3-995
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-995
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.1.0-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.1.1-incubating
>
>
> Add a new method to the {{Authenticator}} interface that will replace the
> current:
> {code}
> public SaslNegotiator newSaslNegotiator();
> {code}
> the preferred new method would be:
> {code}
> public default SaslNegotiator newSaslNegotiator(final InetAddress
> remoteAddress)
> {code}
> This will include deprecation of the old method - this is not a breaking
> change.
> .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
