[
https://issues.apache.org/jira/browse/TINKERPOP-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15038850#comment-15038850
]
ASF GitHub Bot commented on TINKERPOP-995:
------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/162#discussion_r46630315
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/auth/AllowAllAuthenticator.java
---
@@ -41,7 +42,16 @@ public AuthenticatedUser authenticate(final Map<String,
String> credentials) thr
return AuthenticatedUser.ANONYMOUS_USER;
}
+ /**
+ * @deprecated As of release 3.1.1-incubating, replaced by {@link
#newSaslNegotiator(InetAddress)}.
+ * @see <a
href="https://issues.apache.org/jira/browse/TINKERPOP3-995";>TINKERPOP3-995</a>
--- End diff --
i'm not sure that we need to worry about the redirect dropping - i guess we
could discuss a mass find/replace of that stuff. i was going to leave the old
stuff as-is in my thinking this morning, but maybe we shouldn't. probably
something to discuss on the list.
> Add Authenticator.newSaslNegotiator(InetAddress)
> ------------------------------------------------
>
> Key: TINKERPOP-995
> URL: https://issues.apache.org/jira/browse/TINKERPOP-995
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.1.0-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.1.1-incubating
>
>
> Add a new method to the {{Authenticator}} interface that will replace the
> current:
> {code}
> public SaslNegotiator newSaslNegotiator();
> {code}
> the preferred new method would be:
> {code}
> public default SaslNegotiator newSaslNegotiator(final InetAddress
> remoteAddress)
> {code}
> This will include deprecation of the old method - this is not a breaking
> change.
> .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
