Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-163424486
hmm - i suppose it makes sense that this slipped through as we clearly
don't have tests for self-loops.
I've created a JIRA issue for this:
https://issues.apache.org/jira/browse/TINKERPOP-1036
Unfortunately changes to IO are never terribly simple. It will probably
take a little back and forth discussion to cover all the bases...do you mind
doing a little more legwork to get this PR ready to merge? if so....
can you please rename your PR to reference: TINKERPOP-1036 at the start of
the title so that it will hook into our workflow?
Next, my first question is whether or not you've determined if this a
problem for our other two IO formats: gryo and graphson?
finally, please move the test you did add to:
https://github.com/apache/incubator-tinkerpop/blob/master/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/io/IoTest.java#L254
I think that's the best place for it for right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
