[
https://issues.apache.org/jira/browse/TINKERPOP-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15053480#comment-15053480
]
ASF GitHub Bot commented on TINKERPOP-891:
------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/179
TINKERPOP-891 Refactored the sandboxing abstractions for Gremlin Server
https://issues.apache.org/jira/browse/TINKERPOP-891
Deprecated the `SandboxExtension` and replaced it with the
`AbstractSandboxExtension`. Took existing implementations and had them extend
from the new `AbstractSandboxExtension`. Added a new "useful" implementation
called `FileSandboxExtension` which gets its white list configuration from a
file. Updated appropriate docs and wrote a number of tests for the new
`FileSandboxExtension`.
Both unit and integration tests pass. Also tested manually by configuring
Gremlin Server to use the different sandboxes.
VOTE: +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-891
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/179.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #179
----
commit a15b646ade8a106495dbbe29ba803218445bb20e
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2015-12-11T19:56:06Z
Refactored the sandboxing abstractions for Gremlin Server.
Deprecated the SandboxExtension and replaced it with the
AbstractSandboxExtension. Took existing implementations and had them extend
from the new AbstractSandboxExtension. Added a new "useful" implementation
called FileSandboxExtension which gets its white list configuration from a
file. Updated appropriate docs and wrote a number of tests for the new
FileSandboxExtension.
----
> Re-examine Sandboxing Abstractions
> ----------------------------------
>
> Key: TINKERPOP-891
> URL: https://issues.apache.org/jira/browse/TINKERPOP-891
> Project: TinkerPop
> Issue Type: Improvement
> Components: groovy
> Affects Versions: 3.0.2-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.1.1-incubating
>
>
> The sandboxing abstractions are not so good a set of building blocks as I'd
> once thought. Helper methods aren't in the right places and more flexibilty
> is required in managing methods/variables than just simple filters. Need to
> develop more concrete actions on this still.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
