[
https://issues.apache.org/jira/browse/TINKERPOP-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060619#comment-15060619
]
ASF GitHub Bot commented on TINKERPOP-1026:
-------------------------------------------
GitHub user dkuppitz opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/181
TINKERPOP-1026 BVLP should store vertex IDs as String
https://issues.apache.org/jira/browse/TINKERPOP-1026
BLVP (in particular `IncrementalBulkLoader`) now stores the `toString()`
version of vertex IDs in the temporary `bulkLoader.vertex.id` property. I also
added another `BulkLoader` implementation (`OneTimeBulkLoader`), to a) be able
to add more test cases and b) verify that the `toString()` update doesn't
interfere with something else.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1026
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/181.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #181
----
commit 8cc12c0bdd9ac96eb0e4e4f7642c81e8055dad8c
Author: Daniel Kuppitz <[email protected]>
Date: 2015-12-15T21:36:42Z
store the toString() version of vertex IDs and use it for lookups
commit d3ff7533e05d210c5f6bc6ba76d0d2b4944dbde1
Author: Daniel Kuppitz <[email protected]>
Date: 2015-12-16T17:56:28Z
Added another `BulkLoader` implementation (`OneTimeBulkLoader`) to verify
that `id.toString()` vertex lookups still work properly if no temporary
property is written to the target graph.
This will not affect the default behavior of `BLVP`, since
`IncrementalBulkLoader` will still be used by default, but it allowed to add
some more test cases.
commit 2715336642cdb79a12c25e935402954f771dac89
Author: Daniel Kuppitz <[email protected]>
Date: 2015-12-16T18:14:48Z
updated CHANGELOG
----
> BVLP should store vertex IDs as String
> --------------------------------------
>
> Key: TINKERPOP-1026
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1026
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.0.2-incubating
> Reporter: Daniel Kuppitz
> Assignee: Daniel Kuppitz
> Fix For: 3.1.1-incubating
>
>
> Vertex IDs can be types that are not necessarily supported as a property
> type, hence BLVP should store the {{toString()}} variant of vertex IDs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
