[
https://issues.apache.org/jira/browse/TINKERPOP-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097190#comment-15097190
]
ASF GitHub Bot commented on TINKERPOP-824:
------------------------------------------
GitHub user dkuppitz opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/200
TINKERPOP-824 Do we need runtime BigDecimal in more places?
Integrated `NumberHelper` in `SackFunctions`.
* `mvn clean install`: passed
* integration tests: passed
VOTE: +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-824
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/200.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #200
----
commit a2cdeef9e8be6a3f85b0cc59568c1d2ba472957d
Author: Daniel Kuppitz <[email protected]>
Date: 2016-01-13T22:41:04Z
Integrated `NumberHelper` in `SackFunctions`.
----
> Do we need runtime BigDecimal in more places?
> ---------------------------------------------
>
> Key: TINKERPOP-824
> URL: https://issues.apache.org/jira/browse/TINKERPOP-824
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.0.2-incubating
> Reporter: Marko A. Rodriguez
> Assignee: Daniel Kuppitz
> Fix For: 3.1.1-incubating
>
>
> [~mhfrantz] recently made {{Compare}} use {{BigDecimal}} so we don't destroy
> the precision of the underlying {{Number}} object.
> I think we might need this sort of conversion in more places: {{Operator}}
> and {{SackFunctions}}.
> Perhaps a {{NumberHelper}} might be a nice class to have that does the dirty
> work so that future work with numbers is easy and consistently patterned.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
