[
https://issues.apache.org/jira/browse/TINKERPOP-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097514#comment-15097514
]
ASF GitHub Bot commented on TINKERPOP-1083:
-------------------------------------------
Github user dkuppitz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/199#issuecomment-171516783
* code looks good
* `mvn clean install`: passed
* integration tests: passed
VOTE: +1
> Traversal needs a hashCode() and equals() definition.
> -----------------------------------------------------
>
> Key: TINKERPOP-1083
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1083
> Project: TinkerPop
> Issue Type: Bug
> Components: process
> Affects Versions: 3.1.0-incubating
> Reporter: Marko A. Rodriguez
> Assignee: Marko A. Rodriguez
> Fix For: 3.1.1-incubating
>
>
> I notice in {{RepeatStep}} we have {{emitTraversal.hashCode()}} to determine
> the {{hashCode()}} of {{RepeatStep}}. That is bad as we do not have a general
> pattern for determining the {{hashCode()}} for traversals... dah.
> See {{LoopTraversal}} for the hack that was added at some point...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
