GitHub user okram opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/204
TINKERPOP-1089: Order.shuffle implementation is too fragile
https://issues.apache.org/jira/browse/TINKERPOP-1089
This required some refactoring. We have lots of `Comparator` wrappers
everywhere so things get a little nasty. However, I added some solid test cases
that ensure that the order violation doesn't happen with `Order.shuffle`.
VOTE +1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1089
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/204.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #204
----
commit ed66ee3e027787a6c95c7ee9d5d1b09c155ed093
Author: Marko A. Rodriguez <[email protected]>
Date: 2016-01-19T17:36:56Z
fixed Order.shuffle so that it doesn't violate contract. This required some
refactoring. A little cleaner, but I bet we could make it even nicer.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
