[ 
https://issues.apache.org/jira/browse/TINKERPOP-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128988#comment-15128988
 ] 

ASF GitHub Bot commented on TINKERPOP-1041:
-------------------------------------------

GitHub user velo opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/209

    TINKERPOP-1041

    Same as https://github.com/apache/incubator-tinkerpop/pull/207
    
    But target on tp31

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/velo/incubator-tinkerpop TINKERPOP-1041

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #209
    
----
commit a86eb67be014b4de9bc9b8d54a8ee7db8b260442
Author: Marvin Froeder <[email protected]>
Date:   2016-01-21T00:33:56Z

    Enabled build on windows

commit 46f55df71c277a3b00642278d78ea2a7f3922728
Author: Marvin H Froeder <[email protected]>
Date:   2016-01-21T00:46:05Z

    Ignoring rat on eclipse and appveyor files

commit a617751112b364a18ff729f9c5f0e964461497b4
Author: Marvin Froeder <[email protected]>
Date:   2016-01-31T20:47:15Z

    TINKERPOP-1041 - give import thread a chance to run

commit 3c8bf17d03f25b477118810a13c0d962d8698ad3
Author: Marvin Froeder <[email protected]>
Date:   2016-02-01T00:15:33Z

    Url separator is always / even on windows

commit 75c6b562f650043e5f51d8b129c0a1f2a34ec311
Author: Marvin Froeder <[email protected]>
Date:   2016-02-01T04:19:33Z

    Changed back slashes into regular ones

commit f7d8a0a8d21978a664ab65eb9aa8ff799acf915e
Author: Marvin Froeder <[email protected]>
Date:   2016-02-01T04:19:55Z

    Downloading hadoop winutils.exe when using windows

commit 4badd014f107ddd5f91e8545b565eda032ee5bc2
Author: Marvin Froeder <[email protected]>
Date:   2016-02-01T04:39:13Z

    Changed back slashes into regular ones

commit 545e6a702f425c27f1bf99538fdb8b9039030474
Author: Marvin Froeder <[email protected]>
Date:   2016-02-01T21:18:42Z

    Figuring out why travis is sad with me

----


> StructureStandardTestSuite has file I/O issues on Windows
> ---------------------------------------------------------
>
>                 Key: TINKERPOP-1041
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1041
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: test-suite
>    Affects Versions: 3.0.2-incubating
>         Environment: Windows 10, Java 8, TinkerPop version "3.0.2-incubating"
>            Reporter: Martin Häusler
>            Assignee: Jason Plurad
>             Fix For: 3.1.2-incubating
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Most of the tests in StructureStandardTestSuite/IoGraphTest cause an 
> unexpected java.io.IOException. The stack trace looks like this:
> {panel:title=Stack Trace}
> java.io.IOException: The the file name, directory name or volume label syntax 
> is incorrect.
>       at java.io.WinNTFileSystem.createFileExclusively(Native Method)
>       at java.io.File.createTempFile(Unknown Source)
>       at 
> org.apache.tinkerpop.gremlin.TestHelper.generateTempFile(TestHelper.java:74)
>       at 
> org.apache.tinkerpop.gremlin.structure.io.IoGraphTest.shouldReadWriteModernToFileWithHelpers(IoGraphTest.java:164)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>       at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>       at java.lang.reflect.Method.invoke(Unknown Source)
> {panel}
> I'm running the test suite from Eclipse under Java 8, on a Windows 10 x64 
> machine. The dependencies in my project are managed with gradle. 
> Investigating the offinsive line 
> (org.apache.tinkerpop.gremlin.TestHelper.java@74) in the debugger reveals the 
> following parameters of "File.createTempFile(...)":
> {noformat}
> fileName = "shouldReadWriteModernToFileWithHelpers[graphml]"
> fileNameSuffix = ".xml"
> path = 
> "file:\D:\guh\caches\modules-2\files-2.1\org.apache.tinkerpop\gremlin-test\3.0.2-incubating\345ec87b74923b76374111f2e4040d4d105f256\temp"
> {noformat}
> The offensive part is the "path" variable, because it contains the prefix 
> "file:\". I tried the same thing in a dedicated JUnit test without the prefix 
> and it works fine.
> I would be very happy to see this issue fixed, as this considerably reduces 
> the amount of tests in the suite that I can run against my graph 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to