[
https://issues.apache.org/jira/browse/TINKERPOP-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142673#comment-15142673
]
ASF GitHub Bot commented on TINKERPOP-1106:
-------------------------------------------
Github user dkuppitz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/218#issuecomment-182851301
Code looks good, `mvn clean install` passed...
VOTE: +1
> Errors on commit in Gremlin Server don't register as exception on driver
> ------------------------------------------------------------------------
>
> Key: TINKERPOP-1106
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1106
> Project: TinkerPop
> Issue Type: Bug
> Components: server
> Affects Versions: 3.1.1-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Critical
> Fix For: 3.1.2-incubating
>
>
> Because the last message in a result is sent before commit as the terminating
> message, a failure on {{commit()}} will send another message, but the driver
> won't be looking for it and it will not register as an exception on that
> request.
> Seems like the solution would be to save the last message until after commit,
> and if the commit fails, you would send the error back otherwise send the
> last message. In this way the protocol doesn't have to change.
> Also need to determine if exceptions prevent additional iteration of results
> back to the client as discussed here:
> https://groups.google.com/d/msg/gremlin-users/H5IlmZ4Zgyc/ENfScPisCgAJ
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
