Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/215#issuecomment-182853040
A response to each item in your list.
* This will go away when TINKERPOP-1140 is complete. This is a "staging
method" for now.
* This is not a critical performance line of code. This is during
`TraversalSource` construction which is like saying "a database connection
creation method uses stream."
* Same as previous.
* Same as previous -- submitting a `GraphComputer` job is crazy costly
relative to this simple `stream()`.
* This will go away when TINKERPOP-1140 is complete. This is a "staging
method" for now.
* This is test suite setup code. Performance doesn't matter.
* Same as previous.
To your "old code" reference:
* Yes, we should not use `stream()` here. This class needs to be blazing
fast. I believe you and I are the author of this class and we should fix it.
That is for another ticket.
NOTE: We should also remove all the `stream()` work in `StarGraph` (there
is a butt load).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
