Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/209#issuecomment-183328060
Perhaps we should re-calibrate a bit here. The original ticket was about
getting the `StructureStandardTestSuite` working on windows (which can be a
blocker for graph providers doing dev on windows). As far as i can gather,
that much is fixed. As a bonus, @velo got us a build on windows through
appveyor and even got apache infra to enable it for us.
There are some good fixes in this PR as-is and it would be nice to see
appveyors yaml in the main dev branches. Since the original issue is resolved,
let's get this PR up for VOTE. To do that, we need appveyor yaml to change
slightly so that it doesn't fail the build. Since the tests don't all pass,
@velo can you please change the build to `-Dspark-gremlin.skip.tests=true` or
maybe even skip just the failing tests
`-Dspark-gremlin.test.excludes="**/*ExcludeTest.java` - we do that temporarily
until a separate pull request can address those failures (we'll need a new
ticket obviously).
Does that sound reasonable?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
