[
https://issues.apache.org/jira/browse/TINKERPOP-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176637#comment-15176637
]
ASF GitHub Bot commented on TINKERPOP-1160:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/249
TINKERPOP-1160 Add timeout configuration for time to wait for connection
close
https://issues.apache.org/jira/browse/TINKERPOP-1160
Added the new `maxWaitForSessionClose` configuration option to the driver.
For all the code changes here, the only one that matters is this:
https://github.com/apache/incubator-tinkerpop/compare/tp31...TINKERPOP-1160?expand=1#diff-9aa3bff55e6c3f840ceded2dd2ad2d88R234
where I replaced an indefinitely blocking {{get()}} call on a future to one
with a timeout that uses the new setting.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1160
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/249.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #249
----
commit 4247aa6275a0dfdbef0d8d5c222806d3d3bf4d69
Author: Stephen Mallette <[email protected]>
Date: 2016-03-02T19:51:34Z
Minor change to variable definition.
commit 29b052598ecc90296a810b3a8fdb525afbabeb6d
Author: Stephen Mallette <[email protected]>
Date: 2016-03-02T20:48:52Z
Added maxWaitForSessionClose to driver configuration.
This setting configures how long the driver will wait to kill a session
before it just lets the server handle it. Added a bunch of javadoc to the
driver settings.
commit f0fc5e27ba8248396919c6175abff55f9496978c
Author: Stephen Mallette <[email protected]>
Date: 2016-03-02T20:50:31Z
Update changelog.
commit 90b3117b29933741e0a4f29ec38abfb15f35bcb3
Author: Stephen Mallette <[email protected]>
Date: 2016-03-02T20:53:28Z
Update upgrade docs around TINKERPOP-1160
commit d07eb59b6633bba3ba27b4a6f26acc5f4ca64c23
Author: Stephen Mallette <[email protected]>
Date: 2016-03-02T21:32:46Z
The default serializer for settings was not congruent with Cluster.
Made the default for Settings to be gryo like Cluster.
commit 7ebd46cd5fc78e6ce0e6ea58ba1d2cb999284c10
Author: Stephen Mallette <[email protected]>
Date: 2016-03-02T21:34:14Z
Allowed maxWaitForSessionClose to get assigned from the Cluster builder.
This setting was defined through Settings but were not passed along to the
Cluster builder.
commit 5944ee6574b0feb9d2b257768d0dc3a1309697dd
Author: Stephen Mallette <[email protected]>
Date: 2016-03-02T22:16:15Z
Add reference docs for all the driver settings.
----
> Add timeout configuration for time to wait for connection close
> ---------------------------------------------------------------
>
> Key: TINKERPOP-1160
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1160
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver
> Affects Versions: 3.1.1-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Fix For: 3.1.2-incubating
>
>
> Need some sort of configuration to timeout a close operation on in-session
> requests. Without that, a failed close may hang the client in waiting for a
> response - blocking indefinitely.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
