[
https://issues.apache.org/jira/browse/TINKERPOP-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179896#comment-15179896
]
ASF GitHub Bot commented on TINKERPOP-1184:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/252
TINKERPOP-1184 Fixed bug where session close was happening an extra time.
https://issues.apache.org/jira/browse/TINKERPOP-1184
If a session was closed explicitly by the client, the scheduled job to
close the session on expiration was not being cancelled leading to a second
closing. The second closing really wasn't doing anything "bad" but it did
generate extra logging that was confusing if the user had expected the session
to already be closed. Refactored some of the session "kill" operations to make
them a bit more thread safe.
Tested with ` mvn clean install -DskipTests && mvn verify -pl
gremlin-server -DskipIntegrationTests=false -DincludeNeo4j`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1184
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/252.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #252
----
commit 5e19fd65376b2697d1fc423c39fa51e8fa11d7b2
Author: Stephen Mallette <[email protected]>
Date: 2016-03-04T13:43:38Z
Fixed bug where session close was happening an extra time.
If a session was closed explicitly by the client, the scheduled job to
close the session on expiration was not being cancelled leading to a second
closing. The second closing really wasn't doing anything "bad" but it did
generate extra logging that was confusing if the user had expected the session
to already be closed. Refactored some of the session "kill" operations to make
them a bit more thread safe.
----
> Sessions not being closed properly
> ----------------------------------
>
> Key: TINKERPOP-1184
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1184
> Project: TinkerPop
> Issue Type: Bug
> Components: server
> Affects Versions: 3.1.1-incubating
> Reporter: Daniel Kuppitz
> Assignee: stephen mallette
> Fix For: 3.1.2-incubating
>
>
> Currently I see a lot of these messages popping up in the server log:
> {code}
> INFO 00:08:33,402 - Session a70d0aeb-92e2-4ff7-88cf-14108e7533d3 has been
> idle for more than 28800000 milliseconds - preparing to close
> INFO 00:08:33,402 - Session a70d0aeb-92e2-4ff7-88cf-14108e7533d3 closed
> {code}
> I started a bulk loading job more than 8 hours ago, so it seems that it's now
> closing all the sessions that I ever created. Hoever, I'm confident that I'm
> closing sessions properly in my code:
> {code}
> try
> {
> // commit transaction
> }
> catch (Exception ex)
> {
> // handle exception
> }
> finally
> {
> client.close();
> client = null;
> }
> {code}
> Even if the {{client.close()}} call would fail, I should also see different
> messages about leaked client connections in the log, but that's not the case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
