[ 
https://issues.apache.org/jira/browse/TINKERPOP-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181812#comment-15181812
 ] 

stephen mallette commented on TINKERPOP-479:
--------------------------------------------

This is kinda interesting:

{code}
g.V().has("person","name","jon").orCreate()
{code}

so {{orCreate}} would assume that 'name', 'jon' was unique and use that to 
create the vertex. Would you expand {{orCreate}} to take parameters for other 
"initial" properties - like:

{code}
g.V().has("person","name","jon").orCreate("age",42)
{code}

I think that's a pretty common pattern.  You determine existence and then if no 
present initialize a bunch of properties on the newly created vertex.  I'd even 
go so far as to perhaps consider an overload of {{orCreate}} with a 
{{UnaryOperator<Vertex>}} parameter or something so that there was full 
flexibility there to deal with that vertex after creation.

> Consider Providing "getOrCreate" Functionality
> ----------------------------------------------
>
>                 Key: TINKERPOP-479
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-479
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: structure
>    Affects Versions: 3.0.2-incubating
>            Reporter: stephen mallette
>
> One of the most commonly written functions used is good ol' "getOrCreate" 
> where you want to get a {{Vertex}} if it exists or create it with supplied 
> properties if it does not.  We currently have a "helper" function for this on 
> {{ElementHelper}} 
> https://github.com/tinkerpop/tinkerpop3/blob/6d0f00865f673cb0739f6f310e1868425f732924/gremlin-core/src/main/java/com/tinkerpop/gremlin/structure/util/ElementHelper.java#L62
> but perhaps it is time to treat this issue as a first class citizen as part 
> of the Graph API.  I think that some vendors might actually be able to 
> optimize this function as well.  
> Another aspect of "getOrCreate" is "upsert" as well as options to ensure 
> uniqueness.  All of these things we've at some point or another built 
> variations of outside of TinkerPop for applications, data loading, etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to