[ 
https://issues.apache.org/jira/browse/TINKERPOP-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200613#comment-15200613
 ] 

ASF GitHub Bot commented on TINKERPOP-1151:
-------------------------------------------

Github user spmallette commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/233#issuecomment-198128052
  
    I'm not sure if this is right still.  The tests run but i still see this 
message in every module during build:
    
    ```text
    Running org.apache.tinkerpop.gremlin.util.function.ScriptEngineLambdaTest
    Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.648 sec - 
in org.apache.tinkerpop.gremlin.util.function.ScriptEngineLambdaTest
    Running org.apache.tinkerpop.gremlin.groovy.engine.GremlinExecutorTest
    SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
    SLF4J: Defaulting to no-operation (NOP) logger implementation
    SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further 
details.
    ```
    
    I haven't even gotten to testing the actual console distribution, server 
distributions, hadoop/spark/giraph logging.  Can you please post some evidence 
of these things working in full? without that, i don't think i can VOTE 
positively on this.


> slf4j-log4j12 / log4j is only required for testing
> --------------------------------------------------
>
>                 Key: TINKERPOP-1151
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1151
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: build-release
>    Affects Versions: 3.1.0-incubating
>            Reporter: Hendy Irawan
>            Priority: Trivial
>
> Pull request: https://github.com/apache/incubator-tinkerpop/pull/229



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to