Github user spmallette commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/233#issuecomment-198128052
  
    I'm not sure if this is right still.  The tests run but i still see this 
message in every module during build:
    
    ```text
    Running org.apache.tinkerpop.gremlin.util.function.ScriptEngineLambdaTest
    Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.648 sec - 
in org.apache.tinkerpop.gremlin.util.function.ScriptEngineLambdaTest
    Running org.apache.tinkerpop.gremlin.groovy.engine.GremlinExecutorTest
    SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
    SLF4J: Defaulting to no-operation (NOP) logger implementation
    SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further 
details.
    ```
    
    I haven't even gotten to testing the actual console distribution, server 
distributions, hadoop/spark/giraph logging.  Can you please post some evidence 
of these things working in full? without that, i don't think i can VOTE 
positively on this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to