[
https://issues.apache.org/jira/browse/TINKERPOP-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262898#comment-15262898
]
ASF GitHub Bot commented on TINKERPOP-1268:
-------------------------------------------
Github user dkuppitz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/297#issuecomment-215548386
Looks good to me. I prefer this approach for option parsing:
https://github.com/apache/incubator-tinkerpop/blob/master/docker/scripts/build.sh#L40-L50
However, it requires that you handle all possible options and show a usage
message if an option is unknown. That probably doesn't fit well in
`gremlin.sh`, as the Java side is supposed to handle all "unknown" options and
you likely don't want to keep the shell script and the Java side in sync
whenever an option is added / removed.
VOTE: +1
> Improve script execution options for console
> --------------------------------------------
>
> Key: TINKERPOP-1268
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1268
> Project: TinkerPop
> Issue Type: Improvement
> Components: console
> Affects Versions: 3.1.2-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Labels: breaking
> Fix For: 3.2.1
>
>
> Given the discussion here:
> https://pony-poc.apache.org/thread.html/Zhsn1tow4012xpm
> Implement the following:
> 1. Deprecate support for {{ScriptExecutor}}
> 2. Deprecate support of bin/gremlin.sh init.groovy
> 3. Add support for {{bin/gremlin.sh -i init.groovy}} which does the same
> thing as (2) and does not exit the console on failure. That would allow a
> user to work with their console session up to the point of failure.
> 4. Improve support for {{bin/gremlin.sh -e exec.groovy}} to no longer use
> {{ScriptExecutor}} and execute scripts directly in the console for automation
> purposes.
> 5. Add some other options to control output to the console so that you could
> do {{bin/gremlin.sh -q -e exec.groovy}} which would execute in a quiet mode
> with no output, for example.
> The idea would be to try to implement this without breaking change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
