[
https://issues.apache.org/jira/browse/TINKERPOP-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267166#comment-15267166
]
ASF GitHub Bot commented on TINKERPOP-1279:
-------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/300#discussion_r61778514
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/AndP.java
---
@@ -29,11 +32,19 @@
*/
public final class AndP<V> extends ConnectiveP<V> {
- public AndP(final P<V>... predicates) {
+ public AndP(final List<P<V>> predicates) {
super(predicates);
this.biPredicate = new AndBiPredicate(this);
}
+ @Deprecated
+ /**
+ * @deprecated Since 3.2.0 -- use {@link AndP(List)}
--- End diff --
Minor nit.....We've consistently used "As of release 3.2.0-incubating,
replaced by {@link SomeOtherClass#someNewMethod()}" for deprecation comments.
> Add Iterable<V> parameter constructor to ConnectiveP subclasses
> ---------------------------------------------------------------
>
> Key: TINKERPOP-1279
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1279
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.1.0-incubating, 3.1.1-incubating, 3.1.2-incubating
> Reporter: Jad Naous
>
> It's really hard to instantiate an array of generics and pass it to the
> constructor without warnings. Can you please use collections instead of
> arrays in parameters (or add an overloaded constructor)?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
