This command will provide a rough overview of where we use dashed keys:
grep '"[a-zA-Z]*\-[a-zA-Z]*"' $(find
./gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/{structure,process}
-name "*Test*.java")
Not all matches are dashed keys, but most of them.
Cheers,
Daniel
On Tue, May 17, 2016 at 3:14 PM, Marko Rodriguez <okramma...@gmail.com>
wrote:
> Hi,
>
> Yes, if dashes are not supported by an implementer, then we need to have a
> common denominator. And as you say, those tests aren't testing dashes.
>
> Can you ask him to provide a PR that includes the removal of all dashes as
> I believe there are some in the ProcessSuite too…?
>
> Marko.
>
> http://markorodriguez.com
>
> On May 17, 2016, at 4:42 AM, Stephen Mallette <spmalle...@gmail.com>
> wrote:
>
> > We just received this PR from Mathias Bogaert who is working on a Graph
> > implementation:
> >
> > https://github.com/apache/incubator-tinkerpop/pull/315
> >
> > It removes dashes from keys used in our test suite. The nature of those
> > tests is not to enforce that Graphs can support dashes (dashes were just
> > arbitrarily used in the tests), so I'm inclined to support this change.
> > Does anyone feel differently? If so, I think the recommendation would be
> > to specifically create tests that "enforce dashes in key names".
> >
> > If there are no additional comments on this in the next 72 hours (Friday,
> > April 20, 2016, 6:45am EST) I will assume lazy consensus and merge via
> CTR.
>
>
