[
https://issues.apache.org/jira/browse/TINKERPOP-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292025#comment-15292025
]
ASF GitHub Bot commented on TINKERPOP-1305:
-------------------------------------------
Github user dkuppitz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/316#issuecomment-220434331
Even if this PR gets another +1, please don't merge yet, as I'm still doing
lots of manual tests these days. I'm still not sure if I like halted traversers
being stored in the config (simply because I'm not yet at the point where I've
tested this particular change).
And even if my tests are going to run smoothly, I'm still worried about how
scalable this approach is. In a distributed environment, how is the
configuration distributed between worker iterations? Where is it stored? Will
it be (re)loaded for each worker iteration? If so, how long does it take to
load a config that holds millions of halted traversers?
> HALTED_TRAVERSERS hold wrong information
> ----------------------------------------
>
> Key: TINKERPOP-1305
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1305
> Project: TinkerPop
> Issue Type: Bug
> Affects Versions: 3.2.0-incubating
> Reporter: Daniel Kuppitz
> Assignee: Marko A. Rodriguez
>
> {noformat}
> gremlin> g.V().in("knows")
> ==>v[1]
> ==>v[1]
> gremlin>
> g.V().in("knows").store("x").program(BulkDumperVertexProgram.build().create(graph))
> ==>v[1]
> ==>v[1]
> gremlin> hdfs.head("output/~g", GryoInputFormat).each {println "" + it.id() +
> " :: " + it.property(TraversalVertexProgram.HALTED_TRAVERSERS)}
> 4 :: vp[gremlin.traversalVertexProgram.haltedTraversers->[v[5], v[3]]]
> 1 :: vp[gremlin.traversalVertexProgram.haltedTraversers->[v[3], v[2], v[4]]]
> 6 :: vp[gremlin.traversalVertexProgram.haltedTraversers->[v[3]]]
> 3 :: vp[empty]
> 5 :: vp[empty]
> 2 :: vp[empty]
> {noformat}
> Vertex 4 and 6 shouldn't have halted traversers, since they only have
> incoming {{created}} edges. Vertex 1 on the other hand should only hold a
> reference to {{v\[2\]}} and {{v\[4\]}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
