Re: svn commit: r380835 -/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java

[Rainer Jung]

Hi Filip,

I did a little exercise with Java 6 and Solaris DTrace.
The change is in fact OK, although I first thought that the DeltaRequest 
will no longer be initialized:

DeltaManager.createSession() calls

   ManagerBase.createSession()

which in turns calls

      DeltaManager.createEmptySession()
         DeltaManager.getNewDeltaSession()
            DeltaSession.<init>()
               DeltaSession.resetDeltaRequest()

So the DeltaRequest still gets initialized correctly :)

Thanks

Rainer

[EMAIL PROTECTED] wrote:
Author: fhanik
Date: Fri Feb 24 14:19:22 2006
New Revision: 380835

URL: http://svn.apache.org/viewcvs?rev=380835&view=rev
Log:
Fix for bug 
http://issues.apache.org/bugzilla/show_bug.cgi?id=38740
looks like we got trigger happy with the resetDeltaRequest
Thanks to Nick Wesselman and Rainer Jung that pointed this out.


Modified:
    
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java

Modified: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java?rev=380835&r1=380834&r2=380835&view=diff
==============================================================================
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java
 Fri Feb 24 14:19:22 2006
@@ -605,7 +605,6 @@
         }
 
         DeltaSession session = (DeltaSession) super.createSession(sessionId) ;
-        session.resetDeltaRequest();
         if (distribute) {
             sendCreateSession(session.getId(), session);
         }
@@ -633,7 +632,6 @@
             counterSend_EVT_SESSION_CREATED++;
             send(msg);
         }
-        session.resetDeltaRequest();
     }
     
     /**



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]