Github user markt-asf commented on the pull request:
https://github.com/apache/tomcat/pull/28#issuecomment-188460191
Generally I like this patch. I do have a couple of comments:
- I think it makes sense to make the change to a generic approach
immediately. One way of doing this would be for the precompressed init param to
take a comma separated list like ".gz,gzip,.br,br". It would need suitable
sanity checking.
- The preference for different encodings is set by the client, not the
server. See RFC7231, section 5.3.4. Look at o.a.catalina.Request.parseLocales()
for a way of handling q values.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
